[Dnsmasq-discuss] Incorrect use of variable arguments

Simon Kelley simon at thekelleys.org.uk
Mon Feb 11 11:54:49 GMT 2008

Cedric Duval wrote:
> Hi,
> when debug mode is activated, my_syslog() uses its va_list twice without
> properly resetting its state, causing dnsmasq to crash on powerpc.
> The first patch fixes this, and the second one (incremental) just puts
> the va_ macros in more "obvious" places. While not stricly necessary, I
> think it decreases the potential for future bugs caused by an overlooked
> macro mismatch. :)
> No use of C99's va_copy as it may reduce portability for no real gain.

Many thanks, both patches applied for 2.41



More information about the Dnsmasq-discuss mailing list