[Dnsmasq-discuss] Re: Patch (v2) to change dnsmasq logentries

Simon Kelley simon at thekelleys.org.uk
Sun Mar 1 21:01:29 GMT 2009


Olaf Westrik wrote:
> Hi,
> 
> 
> please consider attached patch against dnsmasq 2.47 for inclusion.
> Purpose: easily identify and separate log messages for the DHCP and TFTP
> part.
> Messages from dnsmasq DHCP will be marked with dnsmasq-dhcp as daemon
> name, TFTP will be marked with dnsmasq-tftp. This allows easier
> separation for user presentation.
> 
> No message texts are touched, to avoid the need to re-sync the
> translations.
> 
> I have chosen not to use different facilities (current default is
> LOG_DAEMON), as this IMHO would break syslog, syslog-ng and remote
> syslog setups.
> 
> I purposely did not touch the various die() messages.
> 
> 
> If this modification is too intrusive, I can cook up a patch to make
> this behavior opt-in.
> 

Looks good. I tweaked the code a very small amount, merged it with my
development tree, and posted the results here:

http://www.thekelleys.org.uk/dnsmasq/test-releases/dnsmasq-2.48test4.tar.gz

Please check that works for you.

Cheers,

Simon.



More information about the Dnsmasq-discuss mailing list