[Dnsmasq-discuss] 2.60rc4 bug

[Simon Kelley]

On 29/02/12 23:29, Matthias Andree wrote:
> -----BEGIN PGP SIGNED MESSAGE-----

>
> Also, when building with clang, there are some more warnings about
> unused results in expressions.  I haven't investigated these.  If you
> want to discard results, cast to void (possibly inside some macro):
>
> rfc1035.c:322:9: warning: expression result unused [-Wunused-value]
>            if (!ADD_RDLEN(header, ansp, plen, len))
>                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> rfc1035.c:28:42: note: expanded from:
>      (!CHECK_LEN(header, pp, plen, len) ? 0 : (long)((pp) += (len)), 1)
>                                           ^

I think this may be a genuine problem: does replacing the definition of
ADD_RDLEN at the start of rfc1035.c with

#define ADD_RDLEN(header, pp, plen, len) \
     (!CHECK_LEN(header, pp, plen, len) ? 0 : ((long)((pp) += (len)), 1))

fix it?

Cheers,

Simon.