[Dnsmasq-discuss] [PATCH] dnsmasq-2.68 vs. dnsmasq-2.69rc1 Coverity scan diff

[Tomas Hozza]

----- Original Message -----
> On 24/03/14 13:51, Tomas Hozza wrote:
> > Hi.
> > 
> > I did a version diff scan between 2.68 and 2.69rc1 version.
> >>From my point of view there is one thing worth of fixing,
> > I'm attaching the patch.
> > 
> > I'm also attaching the coverity scan log.
> > 
> > Regards,
> > 
> > Tomas Hozza
> > 
> > 
> 
> Thanks, I agree there's a problem if recvfrom() fails and returns -1.
> The solution is to get the sanity checks right, since is already checks
> that n < sizeof(struct dns_header), just too late. I've committed a fix:
> 
> 
> http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=490f90758dba741b10a2af6b70eb561777575e04 

Looks reasonable, too.

> Cheers,
> 
> Simon.

Hi Simon.

Unfortunately I noticed, that I didn't enabled the new DNSSEC functionality
during the Coverity scan :) I did the scan again and found more issues worth
of fixing.

Please see the attached log and patches.

Regards,

Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Error-FORWARD_NULL-CWE-476.patch
Type: text/x-patch
Size: 1161 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20140325/afbbe16d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Error-RESOURCE_LEAK-CWE-772.patch
Type: text/x-patch
Size: 2065 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20140325/afbbe16d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Error-UNINIT-CWE-457.patch
Type: text/x-patch
Size: 1070 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20140325/afbbe16d/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Error-UNINIT-CWE-457.patch
Type: text/x-patch
Size: 1070 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20140325/afbbe16d/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: csdiff_dnsmasq_2.68-2.69rc1_v2.err
Type: application/octet-stream
Size: 11977 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20140325/afbbe16d/attachment.obj>