[Dnsmasq-discuss] [PATCH] dnsmasq-2.68 vs. dnsmasq-2.69rc1 Coverity scan diff

Dave Taht dave.taht at gmail.com
Tue Mar 25 15:50:04 UTC 2014


did you also compile with dhcpv6 support enabled?

On Tue, Mar 25, 2014 at 7:33 AM, Tomas Hozza <thozza at redhat.com> wrote:
>
>
> ----- Original Message -----
>> On 24/03/14 13:51, Tomas Hozza wrote:
>> > Hi.
>> >
>> > I did a version diff scan between 2.68 and 2.69rc1 version.
>> >>From my point of view there is one thing worth of fixing,
>> > I'm attaching the patch.
>> >
>> > I'm also attaching the coverity scan log.
>> >
>> > Regards,
>> >
>> > Tomas Hozza
>> >
>> >
>>
>> Thanks, I agree there's a problem if recvfrom() fails and returns -1.
>> The solution is to get the sanity checks right, since is already checks
>> that n < sizeof(struct dns_header), just too late. I've committed a fix:
>>
>>
>> http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=490f90758dba741b10a2af6b70eb561777575e04
>
> Looks reasonable, too.
>
>> Cheers,
>>
>> Simon.
>
> Hi Simon.
>
> Unfortunately I noticed, that I didn't enabled the new DNSSEC functionality
> during the Coverity scan :) I did the scan again and found more issues worth
> of fixing.
>
> Please see the attached log and patches.
>
> Regards,
>
> Tomas
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>



-- 
Dave Täht

Fixing bufferbloat with cerowrt: http://www.teklibre.com/cerowrt/subscribe.html



More information about the Dnsmasq-discuss mailing list