[Dnsmasq-discuss] [PATCH] Fix segfault when file extension is not passed in --conf-dir

Simon Kelley simon at thekelleys.org.uk
Thu Oct 2 21:47:03 BST 2014


On 02/10/14 15:03, Tomas Hozza wrote:
> Hello.
> 
> while testing dnsmasq 2.72 I discovered it can fail with segfault.
> 
> Reproducer:
> ./dnsmasq --conf-dir=.,
> 
> I'm attaching a patch.

Thanks, I applied a fix that just ignores empty suffices, the semantics
are defined, and it avoids yet another error message.
> 
> Also I scanned the 2.72 version against 2.71 version with coverity.
> 

> 
>>From the source it looks like the match_suffix is never freed,
> while the ignore_suffix is freed.
> 

Fixed too, for completeness

Cheers,

Simon.

> 
> Regards,
> 




More information about the Dnsmasq-discuss mailing list