[Dnsmasq-discuss] [PATCH] Regression: dnsmasq replies to forwarded query too early when receiving REFUSED response from upstream server

Simon Kelley simon at thekelleys.org.uk
Mon Jan 25 21:56:00 GMT 2016


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Patch applied. Many thanks.

Simon.


On 25/01/16 02:27, Chris Novakovic wrote:
> Treat REFUSED (not SERVFAIL) as an unsuccessful upstream response
> 
> Commit 51967f9807665dae403f1497b827165c5fa1084b began treating
> SERVFAIL as a successful response from an upstream server (thus
> ignoring future responses to the query from other upstream
> servers), but a typo in that commit means that REFUSED responses
> are accidentally being treated as successful instead of SERVFAIL
> responses.
> 
> This commit corrects this typo and provides the behaviour intended
> by commit 51967f9: SERVFAIL responses are considered successful
> (and will be sent back to the requester), while REFUSED responses
> are considered unsuccessful (and dnsmasq will wait for responses
> from other upstream servers that haven't responded yet).
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBCAAGBQJWppnwAAoJEBXN2mrhkTWi+NgQAJkG8EvEPajSZT3b2Uo5j0dF
0FisYp1Xcu6t+u84A5R2NGOTn/pWAcjA2b5Ddx7PYq/3V5p2GSdIDYKCVDmKOrWj
dhkSE9B1eQlP/E15bfxhZ85fY0Bf2nh3/2qVdOU6fU8L4C92h6/0v0FlYit4gP+3
cT1BUEEkJh4Tx78YW8TvWscmi6UPpTcjEd8Rrm2BHmL/CIc5OqqjhE8xrTamrVBd
6jBhFe48O9nTxyzePufsBnzL/Pd8t+qi4isPFzCeh8PGm9zYR0rjhyMzGYvsQvQC
hGeNYT7FdhuxhvItsRPYO7I6d1EG7EBHazjbYPitjsK3Dw7vcC4qLx2PnHBZqmuy
yUqYGCMQnb7l+1zexRMyhL5GsVsnu/webprceOsqlk8rIID0SzBBkb9OnMgsLcQv
mKV1rmr7UcysARaLjNGXmP51Una+CEISiXx3noymIGPQ2aa2S0pPxihlWxWXAiFp
plHmVmQQWNPMh+2Vu/+7UTSphHonFVT1qK8yM254lS3v2pXIVqnNH2tXCfhBp7Mj
X2WIr9XDQV4+x598UdKQnIE4SiRFVpqUcAk1VhRyclZK0EBxuIdJSNoCkI1vnJZi
2y/5vWfGAvwgjbSouzDZSI7GicwfV+fCosvirQ3uCvXba0GsmuJkFFuLR2HYvVf7
oS24geBPqLgwNOY1J5g2
=LWbm
-----END PGP SIGNATURE-----



More information about the Dnsmasq-discuss mailing list