[Dnsmasq-discuss] [PATCH] Add support for unique TFTP root per MAC

Floris Bos bos at je-eigen-domein.nl
Mon Apr 10 00:09:25 BST 2017


On 04/09/2017 11:28 PM, Simon Kelley wrote:
> Patch accepted, with one change
>
>
>> 	  snprintf(daemon->namebuff+oldlen, sizeof(daemon->namebuff)-oldlen, "%.2x-%.2x-%.2x-%.2x-%.2x-%.2x/",
>
> daemon->namebuff is a char *, so sizeof(daemon->namebuff) is 4 or 8 and
> sizeof(daemon->namebuff)-oldlen is a negative number which is a large
> positive number when promoted  to unsigned size_t.

Ah, you are right.

Somehow I had the impression it was a fixed size array, on which 
sizeof() do would work.
Probably confused it with the other namebuff in tftp_request ( char 
namebuff[IF_NAMESIZE]; )

Sorry, and thanks for the commit.



Yours sincerely,

Floris Bos



More information about the Dnsmasq-discuss mailing list