[Dnsmasq-discuss] Announce: dnsmasq-2.77rc4
simon at thekelleys.org.uk
Sun May 21 22:24:04 BST 2017
I think my code has beaten the compiler.
opt->source_netmask will remain set to zero on any code path which
doesn't set addrp and inhibit the execution of the memcpy()
Nevertheless I'll add a check, it took me 10 minutes to conince myself
the able was true.
On 21/05/17 11:49, Matthias Andree wrote:
> Am 20.05.2017 um 22:50 schrieb Simon Kelley:
>> I've just mase the fourth, and probably final, release candidate for
>> dnsmasq-27. Please download, compile and run, and report any problems
>> ASAP. If all looks OK, 2.77 will happen in the next week.
> GCC 5 and 6 also have this complaint, and they are right, unless you
> prove that the address family is either AF_INET or AF_INET6.
> If the latter isn't true, memcpy() copies to whichever garbage address
> was in the stack and picked up by [auto] void *addrp.
> edns0.c: In function 'calc_subnet_opt':
> edns0.c:350:7: warning: 'addrp' may be used uninitialized in this
> function [-Wmaybe-uninitialized]
> memcpy(opt->addr, addrp, len);
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: OpenPGP digital signature
More information about the Dnsmasq-discuss