[Dnsmasq-discuss] Announce: dnsmasq-2.77rc4

[Matthias Andree]

Am 21.05.2017 um 23:49 schrieb Simon Kelley:
> rfc2131.c:839:25: warning: data argument not used by format string
>>> [-Wformat-extra-args]
>>>                    service->basename, layer);
>>>                                       ^
> Taking the patch for this reluctantly. The original code seems better to
> me. Pity is confuses the compiler.

It does not "confuse the compiler", there is an inconsistency.
-Wno-format-extra-args would avoid it.

>> I think you may want to resolve these before 2.77 release time.
>>
>> And when trying to strip down the build disabling all options I expose
>> in FreeBSD, I get these, which are cosmetic and, in the option.c case,
>> are bloat.
>>
>> The attached patch series (against Git master) fixes these. Use git am
>> to apply them in given order, and carefully review 0003* whether the
>> option_len() macro needs to be changed instead.
>>
>>> option.c:910:23: warning: unused function 'add_rev6' [-Wunused-function]
>>> static struct server *add_rev6(struct in6_addr *addr, int msize)
>>>                       ^
>>>
>>> network.c:936:24: warning: unused variable 'l6' [-Wunused-variable]
>>>   struct listener *l, *l6;
>>>                        ^
>> You may consider resolving these before 2.77 with proper #ifdefs. I
>> don't care much.
>>
>>
> I have a policy of leaving such: why complicate the code even more than
> the ifdefs already do?

Alright, perhaps -Wno-unused-variable should then be added late to the
options.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20170522/295da789/attachment.sig>