[Dnsmasq-discuss] [PATCH] Warn about the impact of cache-size on performance

john doe johndoe65534 at mail.com
Mon May 21 07:46:01 BST 2018


On 5/20/2018 10:14 PM, Geert Stappers wrote:
> On Fri, May 11, 2018 at 11:43:02PM +0100, Simon Kelley wrote:
>> On 09/05/18 12:13, Geert Stappers wrote:
>>>   3 files changed, 5 insertions(+), 3 deletions(-)
>>>
>>> Note that this patch contains non-ASCII characters,
>>> those might be mangled during transport ...
>>
>> They were, please could you resend an attachment?
> 
> # git clone git://thekelleys.org.uk/dnsmasq.git
> cd dnsmasq/
> git remote add stappers http://stappers.it/git/dnsmasq
> git fetch stappers
> git checkout -b stappers/warn_cache_size stappers/warn_cache_size
> git diff master
> git checkout master
> git merge stappers/warn_cache_size
> 

Not everyone is using Git. Would have been easier to send (git 
send-email) the patch in a format that is accepted by diff(1).

So one could download the tarball from the following link and then apply 
your patch:

http://www.thekelleys.org.uk/dnsmasq/dnsmasq-2.79.tar.gz

They mabey some reason why the patch is not merged in the oficial 
repository! :)

To the maintainer of dnsmasq; could tags and commit be gpg signed and 
the '--sign-off' option be used while committing?

-- 
John Doe



More information about the Dnsmasq-discuss mailing list