[Dnsmasq-discuss] [PATCH] Simplify options flags

[Simon Kelley]

On 24/10/2018 16:25, Petr Mensik wrote:
> Hi!
> 
> I have not managed it until dnsmasq 2.80 were out, but anyway. I have
> some proposal to simplify handling of options bits. Static analysis
> complains on compiler dead-code optimization. I propose having array
> instead. It adds few defines. But it allows adding any bits to defines
> and moving OPT_LAST. It will resize itself as required.
> 
> It might be possible to change unsigned int to unsigned long. It would
> use 64 bit numbers on x86_64 machines. But I guess it might not be worth
> that optimization.
> 
> Chances to get it merged?
> 
> 

Merged as is. a definite improvement.


Cheers,

Simon.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20181024/39e555a2/attachment.sig>