[Dnsmasq-discuss] [PATCH] Improve UBus support

Jan Willem Janssen j.w.janssen at lxtreme.nl
Tue Apr 2 16:11:39 BST 2019


On Fri, 2019-03-29 at 21:52 +0000, Simon Kelley wrote:
> This all looks sensible, with one exception: the logging in
> set_ubus_listeners() and check_ubus_listeners() and associated with the
> calls to check_ubus_listeners can potentially massively span the logs -
> a long lived error will log multiple lines every time dnsmasq spins its
> event loop. It would be good to have rate limiting there. Set a flag
> after logging the error which inhibits further errors, clear it once a
> normal situation is restored.

Good point. I've reworked my patch to only log errors once and attached it to this mail.
Thanks for reviewing it!

Regards,

  Jan Willem

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Improved-UBus-supported.patch
Type: text/x-patch
Size: 8577 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20190402/f7660a99/attachment.bin>


More information about the Dnsmasq-discuss mailing list