[Dnsmasq-discuss] 'tidying' unused variable warnings

Kevin 'ldir' Darbyshire-Bryant ldir at darbyshire-bryant.me.uk
Tue Mar 10 10:25:57 GMT 2020


Hi Simon,

Feel free to throw these patches away!  Prompted by the recent unused var warning fixes when building on macos, I pondered if the warning suppression was a bit too global.  Some warnings are prompted by not including some code (e.g. DHCPV6 vs no DHCPV6) and I wondered if the warning suppression should be made (inverse) conditional.  It means that if some future change genuinely ends up with us not using a variable we will get a warning.

Probably done at the same time as the whitespace cleanup, if at all :-)

Cheers,

Kevin D-B

gpg: 012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cache.c-tidy-unused-warning.patch
Type: application/octet-stream
Size: 962 bytes
Desc: 0001-cache.c-tidy-unused-warning.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0008.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-dhcp-common.c-tidy-unused.patch
Type: application/octet-stream
Size: 964 bytes
Desc: 0002-dhcp-common.c-tidy-unused.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0009.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-dhcp.c-tidy-unused.patch
Type: application/octet-stream
Size: 718 bytes
Desc: 0003-dhcp.c-tidy-unused.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0010.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dnsmasq.c-tidy-unused.patch
Type: application/octet-stream
Size: 1958 bytes
Desc: 0004-dnsmasq.c-tidy-unused.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0011.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-forward.c-tidy-unused.patch
Type: application/octet-stream
Size: 2123 bytes
Desc: 0005-forward.c-tidy-unused.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0012.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-lease.c-tidy-unused.patch
Type: application/octet-stream
Size: 2337 bytes
Desc: 0006-lease.c-tidy-unused.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0013.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-network.c-tidy-unused.patch
Type: application/octet-stream
Size: 2461 bytes
Desc: 0007-network.c-tidy-unused.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0014.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-rfc3315.c-tidy-unused.patch
Type: application/octet-stream
Size: 908 bytes
Desc: 0008-rfc3315.c-tidy-unused.patch
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200310/f0954a31/attachment-0015.obj>


More information about the Dnsmasq-discuss mailing list