[Dnsmasq-discuss] [PATCH] DHCPv6 - List or Range reservation for single host

Petr Menšík pemensik at redhat.com
Tue Mar 10 14:25:08 GMT 2020



On 3/8/20 5:02 PM, Simon Kelley wrote:
> On 06/03/2020 22:10, Petr Menšík wrote:
>> Hi Simon,
>>
>> I have been adapting this feature to earlier releases and discovered one
>> error with prefixed address assignment. When it is calculating number of
>> addresses from prefixlen, it rotates only 32bit int instead of 64b uint.
>> Only result is assigned to 64b variable.
>>
>> Two examples:
>>
>> dhcp-host=[2000::1230:0:0/92],correct-prefix
>> dhcp-host=[2000::1234:5678:0/92],incorrect-prefix
>>
>> If prefix length is lower than 96, the result is zero. It means
>> incorrect-prefix is not refused as it should. Fix is simple, attaching
>> patch with it. Just rotate 64b int. It is just minor issue, but would be
>> nice to fix it before 2.81 is released.
>>
>> Thanks!
>>
>>
> 
> Patch applied, thanks.
> 
> 
> I'm well aware that there's some important work of yours to fix the
> problem  of interfaces changing index which is not in 2.81. That's not
> forgotten, but I need you assistance with it, and planned to defer to
> 2.82 (which will be much quicker than 2.81). If we can get it done now,
> and you really want it in 2.81 then I'm not ruling that out.
That is a pity. Is there anything I can help to include it in 2.81? If
you have any objections to part of it or whole concept, please say so. I
would rebase the change again.

I was added to Fedora as downstream in late summer [1], have not yet
seen any new bug related to it. It seems not broken entirely, maybe it
just works.

Anyway, if there is anything I can do, please let me know. Feel free to
add me into CC.
> 
> 
> Cheers,
> 
> Simon.
1. https://bugzilla.redhat.com/show_bug.cgi?id=1728701

-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB




More information about the Dnsmasq-discuss mailing list