[Dnsmasq-discuss] [PATCH] dnsmasq unit tests!

[Petr Menšík]

My previous message is waiting for moderation, since my patch is a big one.

On 5/12/20 10:51 PM, Geert Stappers wrote:
> On Mon, May 04, 2020 at 05:02:38PM +0200, Petr Menšík wrote:
...
> 
> I think it is great to have unittests.
> 
> 
> 
> <quote from="Harry Callahan" skipped="yes"/>
> 
> 
> 
>  
>> 1. https://github.com/InfrastructureServices/dnsmasq-tests
>> 2. https://github.com/beakerlib/beakerlib
>> 3. https://github.com/InfrastructureServices/dnsmasq/tree/unittests/tests
> 
> Be aware that I'm a "sysadmin",  not a programmer ...
> 
> 
>> diff --git a/Makefile b/Makefile
>> index 78e25f0..e390745 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -24,7 +24,7 @@ MANDIR        = $(PREFIX)/share/man
>>  LOCALEDIR     = $(PREFIX)/share/locale
>>  BUILDDIR      = $(SRC)
>>  DESTDIR       = 
>> -CFLAGS        = -Wall -W -O2
>> +CFLAGS        = -Wall -W -O2 -ggdb
> 
> How does that effect the regular builds?
It was added by mistake, thank you for pointing to it.
>>  LDFLAGS       = 
>>  COPTS         = 
>>  RPM_OPT_FLAGS = 
> 
>       ....
> 
> To be continued ...
OK, patch cleaned up, should apply without any warning now.
> 

-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dnsmasq-unittests.patch
Type: text/x-patch
Size: 36324 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20200514/db03bbe1/attachment-0001.bin>