<br><br><div class="gmail_quote">On Thu, Apr 9, 2009 at 8:02 PM, Tom Metro <span dir="ltr"><<a href="mailto:tmetro%2Bdnsmasq@gmail.com">tmetro+dnsmasq@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Simon Kelley wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
...dnsmasq-2.48test13 has some of your previous suggestions,<div class="im"><br>
<br>
Prefix each line with transaction-id<br>
</div></blockquote>
<br>
That seems to work fine. I see you got rid of the line that identifies the start of the transaction and the ID, which reflects the mock up I created. I'm just wondering whether it'll be easy enough to figure out what those bare numbers represent. The start of transaction line could address that, but adds another line to the output that isn't otherwise useful. It would be hard to add enough explanatory text to each individual line without making them too verbose. Perhaps a compromise might be sticking an arbitrary tag on the IDs, like TID1971352793, so at least there's something ("TID") to search on in the man page or FAQ.</blockquote>
<div><br></div><div>"txn" would be usual for marking a transaction number. TID appearing in a log would tend to be confused with "thread ID".</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Display option values as dotted-quad or text strings where appropriate.<br>
</blockquote>
<br></div>
Looks good.<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Log client-provided hostname<br>
</blockquote>
<br>
This?<br>
<br>
1101411385 client provides name: mythtv<br>
<br>
It might be better to specifically say "host name," so it isn't confused with client ID (which I'd eventually like to see logged as well).<br>
<br>
I noticed this line was absent if the client didn't send a host name. Given this is output only when extended logging is enabled, the user could probably benefit from knowing when the client has failed send a host name. (Likewise for client ID.)<div class="im">
<br>
<br>
-Tom<br>
<br>
-- <br>
Tom Metro<br>
Venture Logic, Newton, MA, USA<br>
"Enterprise solutions through open source."<br>
Professional Profile: <a href="http://tmetro.venturelogic.com/" target="_blank">http://tmetro.venturelogic.com/</a><br>
<br>
_______________________________________________<br></div><div><div></div><div class="h5">
Dnsmasq-discuss mailing list<br>
<a href="mailto:Dnsmasq-discuss@lists.thekelleys.org.uk" target="_blank">Dnsmasq-discuss@lists.thekelleys.org.uk</a><br>
<a href="http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss" target="_blank">http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss</a><br>
</div></div></blockquote></div><br>