<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 26.04.2018 19:03, Simon Kelley
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:c75b14b0-1b6f-e9a2-66e6-a1a02215e387@thekelleys.org.uk">
<blockquote type="cite" style="color: #000000;">
<pre wrap="">
</pre>
<blockquote type="cite" style="color: #000000;">
<blockquote type="cite" style="color: #000000;">
<pre wrap="">General questions:
- Is there any reason to not use the `enum` for definition lists like
`LOPT_*`?
</pre>
</blockquote>
<pre wrap="">No strong ones, just habit I guess.
</pre>
</blockquote>
<pre wrap="">Can this be refactored to simplify the code?
</pre>
</blockquote>
<pre wrap="">It can be refactored, yes, but it probably won't simplify things.
</pre>
</blockquote>
<p>Not having to count manually is a simplification and it avoids
mistakes.<br>
Please check out my patch for introducing enums:</p>
<p><a class="moz-txt-link-freetext" href="https://github.com/digineo/dnsmasq/compare/enums">https://github.com/digineo/dnsmasq/compare/enums</a><br>
</p>
Regards<br>
Julian<br>
</body>
</html>