<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}
p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div><br></div><div>On Sun, Jul 12, 2020, at 3:05 PM, Pali Rohár wrote:<br></div><blockquote type="cite" id="qt" style=""><div>"FOO ?= foo" syntax is not supported by POSIX make:<br></div><div><a href="https://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html">https://pubs.opengroup.org/onlinepubs/9699919799/utilities/make.html</a><br></div><div><br></div><div>And requires some GNU Make extension.<br></div><div><br></div><div>I guess because dnsmasq is supported also on non-GNU Make systems, it<br></div><div>cannot take some patch which adds dependency on Linux or GNU specific<br></div><div>feature.<br></div></blockquote><div><br></div><div>Fair enough, that is a good reason to not take the patch. I suppose POSIX and GNU Make alike gives one the -e sledgehammer.<br></div><div><br></div><blockquote type="cite" id="qt" style=""><div>Basically I do not understand whole point of this patch. If you for<br></div><div>compilation need to override some Makefile variable, why do you not<br></div><div>set correct value of that variable?<br></div><div><br></div><div>It is lot of easier to set correct value during compilation as patching<br></div><div>sources or sending patch to upstream and waiting if it would be released<br></div><div>in new version.<br></div></blockquote><div><br></div><div>Oh we will certainly do that if the patch is rejected, and it is not too hard. They way I think about it is that the effort isn't worth it for *just* one package and one distro, but there are other distros, and subscribers may maintain other projects, so it is still worth raising these issue for the butterfly effect.<br></div><div><br></div><div>The ultimate goal is, as ever, to harmonize packages so the distros are more automated, so in turn the distro maintainers can focus their efforts elsewhere on things that upstream developers want, completing a virtuous cycle.<br></div><div><br></div><blockquote type="cite" id="qt" style=""><div>> P.S. Sorry I am missing the right "in-reply-to"; I turned on message delivery after the original emails were sent, and do not know how to get the message-id from the pipermail archive.<br></div><div><br></div><div>You can find Message-Id of every email in GZIP archive available at:<br></div><div><a href="http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/">http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/</a><br></div></blockquote><div><br></div><div>Ah, great tip! Thanks :)<br></div><div><br></div><div>Thanks,<br></div><div><br></div><div>John<br></div></body></html>