<html><head>
<style id="css_styles" type="text/css">blockquote.cite { margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc }
blockquote.cite2 {margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc; margin-top: 3px; padding-top: 0px; }
a img { border: 0px; }
li[style='text-align: center;'], li[style='text-align: right;'] { list-style-position: inside;}
body { font-family: Tahoma; font-size: 12pt; }</style></head><body class="plain"><div>On 06.01.2023 04:33:39, Peter Tirsek wrote:</div>
<div><br /></div>
<div id="xcc4750ea460a4c4"><blockquote type="cite" class="cite2">
<div class="plain_line">This patch extends the `--address` option to accept two new special</div>
<div class="plain_line">address, `!4` and `!6`, which will cause the server to block A or AAAA</div>
<div class="plain_line">queries for the specified domain(s), respectively. This can be useful</div>
<div class="plain_line">in situations where IPv6 connectivity is broken, but only to certain</div>
<div class="plain_line">domains.</div></blockquote><div id="xcc4750ea460a4c4"><br /></div>I may be a bit late, but somehow, naming the options '!4' and '!6' does not sit right with me.</div><div id="xcc4750ea460a4c4"><br /></div><div id="xcc4750ea460a4c4">If I understand correctly, your patch is about blocking specific query types (namely A and AAAA), rather than blocking IPv4 or IPv6. </div><div id="xcc4750ea460a4c4"><br /></div><div id="xcc4750ea460a4c4">I'd prefer to see that reflected in the option name. </div><div id="xcc4750ea460a4c4"><br /></div><div id="xcc4750ea460a4c4">Thinking along the lines of query type would also point at potential issues with reverse lookups (query type PTR), which -going by your motivation- could be required to be dealt with as well?</div><div id="xcc4750ea460a4c4"><br /></div><div id="xcc4750ea460a4c4">It may also hint at the possibility of a more generic patch, allowing to block other query types as well (PTR, MX, ...).</div><div id="xcc4750ea460a4c4"><br /></div><div id="xcc4750ea460a4c4">For what it's worth, you may want to take a look at how Pi-hole (which is based on a specialised dnsmasq fork) is tackling filtering by query type - see <a href="https://docs.pi-hole.net/regex/pi-hole/#only-match-specific-query-types" style="font-size: 12pt;">https://docs.pi-hole.net/regex/pi-hole/#only-match-specific-query-types</a></div><div id="xcc4750ea460a4c4"><br /></div><div id="xcc4750ea460a4c4">Kind regards, </div><div id="xcc4750ea460a4c4"> Buck</div><div id="xcc4750ea460a4c4"><br /></div><div id="xcc4750ea460a4c4"><br /></div>
</body></html>