<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hi!</p>
<p>Our coverity scan detected new CLANG warning after I have
cherry-picked commit 03345ecefeb0d82e3c3a4c28f27c3554f0611b39 [1]
into our rhel8 release. It reported it for 2.79 version, but even
the last commit in master branch still has the same issue present.
In attached patch I have suggested fix.</p>
<p>I am not sure how to trigger this code from the client, so this
is not tested with real dhcp client. I track it under Fedora bug
[2]. Coverity reported it as:</p>
<pre class="bz_comment_text" id="comment_text_0">1. Defect type: CLANG_WARNING
1. dnsmasq-2.79/src/rfc3315.c:344:7: warning[deadcode.DeadStores]: Value stored to 'outmsgtype' is never read
# 342|
# 343| {
# 344|-> outmsgtype = DHCP6REPLY;
# 345| o1 = new_opt6(OPTION6_STATUS_CODE);
# 346| put_opt6_short(DHCP6USEMULTI);</pre>
<p></p>
<p>1.
<a class="moz-txt-link-freetext" href="http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=03345ecefeb0d82e3c3a4c28f27c3554f0611b39">http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=03345ecefeb0d82e3c3a4c28f27c3554f0611b39</a><br>
2. <a class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=2178069">https://bugzilla.redhat.com/show_bug.cgi?id=2178069</a><br>
</p>
<pre class="moz-signature" cols="72">--
Petr Menšík
Software Engineer, RHEL
Red Hat, <a class="moz-txt-link-freetext" href="http://www.redhat.com/">http://www.redhat.com/</a>
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB</pre>
</body>
</html>