[Dnsmasq-discuss] log messages

[Tom Metro]

Simon Kelley wrote:
> ...dnsmasq-2.48test13  has some of your previous suggestions,
> 
> Prefix each line with transaction-id

That seems to work fine. I see you got rid of the line that identifies 
the start of the transaction and the ID, which reflects the mock up I 
created. I'm just wondering whether it'll be easy enough to figure out 
what those bare numbers represent. The start of transaction line could 
address that, but adds another line to the output that isn't otherwise 
useful. It would be hard to add enough explanatory text to each 
individual line without making them too verbose. Perhaps a compromise 
might be sticking an arbitrary tag on the IDs, like TID1971352793, so at 
least there's something ("TID") to search on in the man page or FAQ.


> Display option values as dotted-quad or text strings where appropriate.

Looks good.


> Log client-provided hostname

This?

1101411385 client provides name: mythtv

It might be better to specifically say "host name," so it isn't confused 
with client ID (which I'd eventually like to see logged as well).

I noticed this line was absent if the client didn't send a host name. 
Given this is output only when extended logging is enabled, the user 
could probably benefit from knowing when the client has failed send a 
host name. (Likewise for client ID.)

  -Tom

-- 
Tom Metro
Venture Logic, Newton, MA, USA
"Enterprise solutions through open source."
Professional Profile: http://tmetro.venturelogic.com/