[Dnsmasq-discuss] [PATCH] Add support for autotools

[Matthias Andree]

Am 10.09.2012 04:05, schrieb Cristian Rodríguez:
> El 09/09/12 22:10, richardvoigt at gmail.com escribió:
>> Completely aside from arguments over the merits of autotools, this
>> patch is not production-ready.
>>
>> It makes unrelated changes.  Removal of the copyright notice is
>> certainly not necessary for use of autotools.
> 
> Where did I removed copyright from the files ? huh ?
> 
>> It breaks the documentation, which will no longer accurately describe
>> the steps needed for build and installation.
> 
> Ok, that can be fixed.
> 
> 
>> And dumping a patch out on a mailing list without introduction or
>> explanation is inadvisable if you want it to be favorably received.
> 
> I sent a patch in the hope other people may find it useful and suitable
> for their use.
> 
> 
>> Especially when it's the first message ever sent by that user to the
>> list.  You've not participated in any discussion.
> 
> That's because I prefer to do social life with a beer and music :-)
> 
> we have literally thousands other of bugs and build problems to fix and
> not much time..
> 
>>  You've done nothing
>> to show that you actually understand the "typical" deployment of
>> dnsmasq.  OpenSuSE is quite atypical of dnsmasq installations.  Have
>> you tested the patch on any other platforms?
> 
> I expect other people to report issues with it, people that has an
> interest of this "other platforms". I encourage them to let me to know
> if it fails for them.

Perhaps I am misjudging your intentions, but this does look bold to me.

You dump this in someone else's lap, in the hopes it might be useful,
and leave it to others to test and report and fix problems with your
approach, because you have "not [got] much time". IOW, you EXPECT this
to be accepted and cause regressions.

Next time state clearly what you want to achieve with that, something
along the lines "We've found this useful for our packaging. It is
tailored to our house's stuff, and needs work somewhere else, but if you
think it is helpful, be our guest." would not have been ill-advised.