[Dnsmasq-discuss] SIGHUP issue

[Simon Kelley]

On 13/02/13 22:17, C V wrote:
> 
> 
> 
> 
>> Sent: Wed, February 13, 2013 12:19:51 PM
>> Subject: [Dnsmasq-discuss] SIGHUP issue
>>
> 
>> The only 1 time I have been able to reproduce  by hand is by trying it on a 
>> long-running (many days) process in a cloud  that was not being used actively.
>>
> 
> 
> OK this part is reproducible and may not be the real problem. In this case the 
> logrotate causes dnsmasq to not write to the new dnsmasq.log file. It writes to 
> the old file (dnsmasq.log-20130213). The logs indicate that SIGHUP indeed is 
> processed.
> 
> There is a bug in our logrotate config
> postrotate
>         [ ! -f /var/run/dnsmasq.pid ] || kill -USR2 `cat /var/run/dnsmasq.pid`
> 
> should be
> postrotate
>         [ ! -f /var/run/dnsmasq.pid ] || kill -USR2 `cat 
> /var/run/dnsmasq/dnsmasq.pid`
> 
> 

I'm confused now if there's a real problem or not. Certainly there is no
problem with SIGHUP that I know of.

A question: do you ever restart dnsmasq? Is there are race between
restarts and SIGHUP before the pidfile contents are valid?

Cheers,

Simon.