[Dnsmasq-discuss] [PATCH] dnsmasq-2.68 vs. dnsmasq-2.69rc1 Coverity scan diff

Simon Kelley simon at thekelleys.org.uk
Mon Mar 24 22:11:52 UTC 2014


On 24/03/14 13:51, Tomas Hozza wrote:
> Hi.
> 
> I did a version diff scan between 2.68 and 2.69rc1 version.
>>From my point of view there is one thing worth of fixing,
> I'm attaching the patch.
> 
> I'm also attaching the coverity scan log.
> 
> Regards,
> 
> Tomas Hozza
> 
> 

Thanks, I agree there's a problem if recvfrom() fails and returns -1.
The solution is to get the sanity checks right, since is already checks
that n < sizeof(struct dns_header), just too late. I've committed a fix:


http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=490f90758dba741b10a2af6b70eb561777575e04


Cheers,

Simon.




More information about the Dnsmasq-discuss mailing list