[Dnsmasq-discuss] Hint needed: neither patched 'dnsmasq 2.75' nor '2.76test4' will compile

[Simon Kelley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 05/01/16 20:55, Matthias Andree wrote:

> However, I can reproduce the issue on a vanilla 2.76test4,
> apparently an #undef HAVE_DHCP isn't properly supported in
> 2.76test4.
> 
> Simon, do you need to comment out the do_script_run() calls in 
> dnsmasq.c::main(), or does the do_script_run() need to remain
> enabled? Minimum command to reproduce the issue on a pristine
> 2.76test4:
> 
> sed -i src/config.h -e 's|#define HAVE_DHCP|//#define HAVE_DHCP|g'
> \ && make -j4
> 

The do_script_run calls need to be removed from the compilation when
DHCP is not included. Since the scripting system used to just about
DHCP events, it was automatically removed from the compilation when
DHCP was removed. Now the script system handles tftp and (in the
latest code) ARP events, so it's no longer conditional on DHCP being
included. This is fall-out from that change.

Conditional combination has a nasty combinatorial explosion. I should
hack up a regression test to build all possible variants.

Fix pushed to git.

Cheers,

Simon.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBCAAGBQJWjVciAAoJEBXN2mrhkTWixqsP/j7bbVmkTi+SsvTlX/GvL9MJ
GI2hKugGsbD+wHdncymkrXnKRPb+m2clDSBcEdcyF7FA33Hosbo9XC3mJb8FUimh
KeaS8tkcjfFG6MKCSiTOxS6WaZ+Qu/YnerDKsJJ+mOZUiK0Aa8kVix4/967pvtv9
Z82M8J18GDtoDLXT4LfMR15oaaYATxgBZEH0dX7nAw4vHDvJZ7paV+E/O/BYWEn/
7pd83XmjTE+NV6WcZExFegG/4c7SIfA0D02bdWw3BFoEM3czn7+/4UAW1YL1H/Wl
kjwqyqUa+ftmARfiYUnpzzEySeGj2gKDG5you14d5zfTzNXBazfPS+k1TfSotXmL
Hk8bErDdKDQuy9xcl7hdSZObS7tCMOGP0OnOu3aJt2vxPVA0SVYqlFXbAhsIB4+h
mt2TfDwBPJr1HkSCKdL2q6toWkzeILgJNfjDTBc+zD1nNsYbCMRqDOftDOGdU4lf
oBUTcU3Ncqm5mDQR/+ofRghacKYUUulkgo+OAVrmOs6O2IpcMds+07PWDnR8xm19
Ogs9V+Qrqkbx0sZwzwUs4fpKbQbZ4SESCIRhnRVTyvwlvjPZkZoSsPUsUW2yIfu3
w4XwA0cwVh4mx1pnbNBp03C96SJPWe95dRegDquW1yxbBsg3F9RDFPSaSyK17PDm
oO5PH7vtHb4mQiH99dq0
=uGJS
-----END PGP SIGNATURE-----