[Dnsmasq-discuss] reproducible segmentation fault - bisected!

[Kevin Darbyshire-Bryant]

On 28/08/17 17:27, Christian Kujau wrote:
> On Mon, 28 Aug 2017, Christian Kujau wrote:
>> On Mon, 28 Aug 2017, Kevin Darbyshire-Bryant wrote:
>>> My workaround is to only call memset if the difference between buffer begin
>>> and buffer limit is bigger than the query length, thus it retains Simon's
>>> intent of clearing memory most of the time but avoids the SIGSEGV trampling.
>>
>> Thanks, with your patch dnsmasq doesn't crash anymore when receiving odd
>> EDNS packets from dnseval.

Here is a fix rather than my sticking plaster workaround.  My workaround 
patch would actually allow dnsmasq to generate invalid replies, this 
actually *fixes* the problem!

Cheers,

Kevin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-forward.c-fix-CVE-2017-13704.patch
Type: text/x-patch
Size: 1251 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20170829/6dc3cf49/attachment.bin>