[Dnsmasq-discuss] [PATCH] nettle hash lookup

[Petr Menšík]

Hi again,

I reworked the original patch to contain fallback for older version of
nettle. It will work fine on more recent version (should be a bit faster
than original code), but still will compile for older libraries.

On 02/26/2018 09:12 PM, Petr Menšík wrote:
> Hi again,
> 
> We at Fedora use dynamic linking for all libraries. We had breakage of
> dnsmasq build more than once, because dnsmasq is using directly
> nettle_hash array. If its size changes, dynamic linker will refuse to
> link it. For that reason, accessing hash array directly makes trouble.
> There is however special function that looks like very similar to
> hash_find() of dnsmasq, that iterates the array internally. It requires
> nettle 3.4, but I think that is already old enough. It would help
> preventing any more linker conflict, if library data changes.
> 
> Do you think older library version should be supported as well?
> 
> Best regards,
> 
> 
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
> 

-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com  PGP: 65C6C973
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Do-not-use-nettle_hashes-directly-use-function-for-h.patch
Type: text/x-patch
Size: 1732 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20180315/691f8873/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20180315/691f8873/attachment.sig>