[Dnsmasq-discuss] [PATCH] Simplify options flags

Petr Mensik pemensik at redhat.com
Wed Oct 24 16:25:31 BST 2018


Hi!

I have not managed it until dnsmasq 2.80 were out, but anyway. I have
some proposal to simplify handling of options bits. Static analysis
complains on compiler dead-code optimization. I propose having array
instead. It adds few defines. But it allows adding any bits to defines
and moving OPT_LAST. It will resize itself as required.

It might be possible to change unsigned int to unsigned long. It would
use 64 bit numbers on x86_64 machines. But I guess it might not be worth
that optimization.

Chances to get it merged?
-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com  PGP: 65C6C973
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Simplify-options-bits.patch
Type: text/x-patch
Size: 2534 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20181024/301765a5/attachment.bin>


More information about the Dnsmasq-discuss mailing list