[Dnsmasq-discuss] Infinite(?) RTR-ADVERTs being sent out [in Ubuntu NetworkManager testuite]

Iain Lane laney at ubuntu.com
Fri Dec 21 22:42:10 GMT 2018


Thanks Simon. I'm more or less offline for the holidays from now on, but
I did test this and it didn't resolve the problem, I'm sorry to say.

Cheers,
Iain

On Thu, Dec 20, 2018 at 11:36:46PM +0000, Simon Kelley wrote:
> Patch below is untested because I'm away from my test rig, but it would
> seem to do the right thing, ie set template->if_index _before_ calling
> ra_start_unsolicited() so that if we re-enter here via an async event it
> doesn't get called again.
> 
> If you could test it in your harness, that would be great :)
> 
> Cheers,
> 
> Simon.
> 
> 
> 
> diff --git a/src/dhcp6.c b/src/dhcp6.c
> index 3932cc7..4082504 100644
> --- a/src/dhcp6.c
> +++ b/src/dhcp6.c
> @@ -650,12 +650,11 @@ static int construct_worker(struct in6_addr
> *local, int prefix,
>             /* First time found, do fast RA. */
>             if (template->if_index != if_index ||
> !IN6_ARE_ADDR_EQUAL(&template->local6, local))
>               {
> +               template->if_index = if_index;
> +               template->local6 = *local;
>                 ra_start_unsolicited(param->now, template);
>                 param->newone = 1;
>               }
> -
> -           template->if_index = if_index;
> -           template->local6 = *local;
>           }
> 
>        }
> 

-- 
Iain Lane                                  [ iain at orangesquash.org.uk ]
Debian Developer                                   [ laney at debian.org ]
Ubuntu Developer                                   [ laney at ubuntu.com ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20181221/b7e7e818/attachment.sig>


More information about the Dnsmasq-discuss mailing list