[Dnsmasq-discuss] code style

[Simon Kelley]

On 11/09/2019 22:12, Shota Hino wrote:
> How do you feel about the mix usage of tab and leading white spaces?
> The code is mangled because some liens use a tab and some use white spaces.
> I do not think the choice of tab vs white spaces is code representation.

With tab stops set to 8, a single tab or eight spaces are just alternate
representations of the same thing, surely?


Simon

> 
> 
> 
> On Wed, Sep 11, 2019 at 2:05 PM Simon Kelley <simon at thekelleys.org.uk
> <mailto:simon at thekelleys.org.uk>> wrote:
> 
>     There seems to be confusion here between code style, and code
>     representation.
> 
>     Code style, ie layout, indent width, is not negotiable.
> 
>     Code representation is the use of tab characters at 8-character stops.
>     If your IDE or other device doesn't use 8 characher stops, it will
>     mangle code. That doesn't mean the code is badly formatted, it means
>     your display method is incompatible.
> 
>     It's quite possible to get around this by running expand on every
>     commit, so that only spaces are used in the repo. It's even possible to
>     run expand on every existing file, at the expense of polluting the logs.
>     I don't think there are any other downsides to this.
> 
>     Or people could  configure IDEs and editors to use sane tab stops.
> 
>     Cheers,
> 
>     Simon.
> 
>     On 07/09/2019 18:21, john doe wrote:
>     > On 9/7/2019 6:25 PM, Shota Hino wrote:
>     >> Whatever the width of the tab is, converting all tabs to
>     whitespaces (or
>     >> the other way around) would be better.
>     >> If code formatting was forced at the time of each commit, there
>     would be no
>     >> need for anybody to set the tab width on their editor.
>     >> Consistent coding style will help more developers in the future.
>     >>
>     >>
>     >>
>     >
>     > I agree, consistent code is best, clear guideline could be usefull for
>     > new code.
>     > Simon Kelley, the belligerent dictator of the Dnsmasq project will
>     need
>     > to way in on such changes though.
>     >
>     > --
>     > John Doe
>     >
>     > _______________________________________________
>     > Dnsmasq-discuss mailing list
>     > Dnsmasq-discuss at lists.thekelleys.org.uk
>     <mailto:Dnsmasq-discuss at lists.thekelleys.org.uk>
>     > http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>     >
> 
>     _______________________________________________
>     Dnsmasq-discuss mailing list
>     Dnsmasq-discuss at lists.thekelleys.org.uk
>     <mailto:Dnsmasq-discuss at lists.thekelleys.org.uk>
>     http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
>