[Dnsmasq-discuss] Dnsmasq version is displayed as "UNKNOWN" on complied version

[Geert Stappers]

On Fri, Jan 31, 2020 at 10:33:46PM +0000, Simon Kelley wrote:
> On 31/01/2020 12:34, Abhishek Patti wrote:
> > 
> > I have complied dnsmasq from source using following dockerfile
> > 
> > " 
> > FROM ubuntu:bionic
> > MAINTAINER "Abhishek Patti <abpatti at cisco.com <mailto:abpatti at cisco.com>>"
> > 
> > RUN apt-get update && apt-get install -y gettext
> > libnetfilter-conntrack-dev libidn2-dev libdbus-1-dev libgmp-dev
> > nettle-dev libbsd-dev liblua5.2-dev build-essential devscripts
> > COPY dnsmasq ./
> > RUN debuild -b -uc -us
> > 
> > "
> > this gives me dnsmasq_2.81-1_all.deb 
> > 
> > however when i upgrade existing/running version of dnsmasq (2.79) on
> > ubuntu and run command "dnsmasq --version:, it upgraded successfully but
> > shows "UNKNOWN"
> > 
> > " dnsmasq --version
> > Dnsmasq version UNKNOWN  Copyright (c) 2000-2020 Simon Kelley
> > Compile time options: IPv6 GNU-getopt DBus no-UBus i18n IDN2 DHCP DHCPv6
> > no-Lua TFTP conntrack ipset auth DNSSEC loop-detect inotify dumpfile
> > 
> > This software comes with ABSOLUTELY NO WARRANTY.
> > Dnsmasq is free software, and you are welcome to redistribute it
> > under the terms of the GNU General Public License, version 2 or 3."
> > 
> > Please let me know
> > 
> 
> 
> The version string compiled into the code is derived from the git tags,
> either directly from git is you're compiling in a git repository, or
> from a substituted format string if you're compiling from from tarball
> extracted from a git repository. Failing either of those, you can edit a
> suitable string into the file VERSION to get something useful.
> 

--- a/bld/get-version
+++ b/bld/get-version
@@ -23,7 +23,7 @@ if which git >/dev/null 2>&1 && \
     git describe | sed 's/^v//'
 elif grep '\$Format:%d\$' $1/VERSION >/dev/null 2>&1; then
     # unsubstituted VERSION, but no git available.
-    echo UNKNOWN
+    echo HOMEMADE
 else
      vers=`cat $1/VERSION | sed 's/[(), ]/,/ g' | tr ',' '\n' | grep ^v[0-9]`
 


Cheers
Geert Stappers