[Dnsmasq-discuss] NETLINK_NO_ENOBUFS not defined on old platforms

Geert Stappers stappers at stappers.nl
Thu Mar 19 20:30:00 GMT 2020


On Thu, Mar 19, 2020 at 01:16:11PM +0000, Petr Gotthard wrote:
> Hello,
> 
> The commit
> http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commitdiff;h=1627d577af03cdf747285e79fa747b6aaae8033f
> 
> introduced NETLINK_NO_ENOBUFS, which is not available on some ancient platforms (which are however still in use).
> 
> The build of 2.81rc4 fails on these platforms now.
> Would it be possible to have #ifdefs around that, please?
> 
> 
> Regards,
> Petr
> 
> diff -Nru dnsmasq-2.81rc4/src/netlink.c dnsmasq-2.81rc4.modified/src/netlink.c
> --- dnsmasq-2.81rc4/src/netlink.c       2020-03-19 13:54:37.804346907 +0100
> +++ dnsmasq-2.81rc4.modified/src/netlink.c      2020-03-19 13:53:14.868860449 +0100
> @@ -79,7 +79,9 @@
>      }
> 
>    if (daemon->netlinkfd == -1 ||
> +#ifdef NETLINK_NO_ENOBUFS
>        setsockopt(daemon->netlinkfd, SOL_NETLINK, NETLINK_NO_ENOBUFS, &opt, sizeof(opt)) == -1 ||
> +#endif
>        getsockname(daemon->netlinkfd, (struct sockaddr *)&addr, &slen) == -1)
>      die(_("cannot create netlink socket: %s"), NULL, EC_MISC);
> 
> 

Thanks.

FWIW in case it gets too silent
  resend the patch as `git format-patch` artifact


Regards
Geert Stappers
-- 
Silence is hard to parse



More information about the Dnsmasq-discuss mailing list