[Dnsmasq-discuss] [PATCH] dnsmasq unit tests!

Geert Stappers stappers at stappers.nl
Thu May 21 15:32:01 BST 2020


On Thu, May 14, 2020 at 09:08:09PM +0200, Petr Menšík wrote:
> My previous message is waiting for moderation, since my patch is a big one.
> 
> On 5/12/20 10:51 PM, Geert Stappers wrote:
> > On Mon, May 04, 2020 at 05:02:38PM +0200, Petr Menšík wrote:
> ...
> > 
> > I think it is great to have unittests.
> > 
> >       ....
> > 
> > To be continued ...
> OK, patch cleaned up, should apply without any warning now.
> 

Yes, works fine.  Fixes the parameter count mismatch that was seen
earlier. One unittest failed as warned before. And yes indeed
the Harald Jensas's patch 'Fix regression in s_config_in_context()
method' does solve it.


Cheers
Geert Stappers
(Curious who also
 says: "Unittests? Yes, have it in the dnsmasq source tree!" )



More information about the Dnsmasq-discuss mailing list