[Dnsmasq-discuss] Fwd: [PATCH] Makefile: make variables overridable

Geert Stappers stappers at stappers.nl
Sat Jul 11 20:32:32 BST 2020


On Sat, Jul 11, 2020 at 07:33:07PM +0200, john doe wrote:
> On 7/11/2020 4:17 PM, Geert Stappers wrote:
> > On Sat, Jul 11, 2020 at 02:33:36PM +0200, betaboon wrote:
> > > Hello Simon, hello everyone.
> > > 
> > > when cross-compiling dnsmasq for armv7 in nixos we ran into the
> > > Makefile not picking up the variables properly.
> > > 
> > > for now we are maintaining the attached patch in our package-tree to
> > > get around this issue, but would love to upstream this to you.
> > > 
> > > The issue in question can be found here:
> > > https://github.com/NixOS/nixpkgs/pull/91422
> > 
> > That "pull request" says the reason
> > is https://github.com/NixOS/nixpkgs/pull/91418
> > 
> > The "#91418" mentions
> > 
> > dbus.c:21:10: fatal error: dbus/dbus.h: No such file or directory
> >     21 | #include <dbus/dbus.h>
> >        |          ^~~~~~~~~~~~~
> > 
> > 
> > > 
> > > >From 41d49b07a32625839f267a45379297066a7879ca Mon Sep 17 00:00:00 2001
> > > From: betaboon <betaboon at 0x80.ninja>
> > > Date: Tue, 30 Jun 2020 12:13:41 +0200
> > > Subject: [PATCH] Makefile: make variables overridable
> > > 
> > > ---
> > >   Makefile | 38 +++++++++++++++++++-------------------
> > >   1 file changed, 19 insertions(+), 19 deletions(-)
> > > 
> > > diff --git a/Makefile b/Makefile
> > > index 78e25f0..8e44354 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > 
> > >   # Variables you may well want to override.
> > > 
> > > -PREFIX        = /usr/local
  ...
> > > +PREFIX        ?= /usr/local
  ...
> > > -SRC = src
> > > -PO  = po
> > > -MAN = man
> > > +SRC ?= src
> > > +PO  ?= po
> > > +MAN ?= man
  ...
> > > 
> > 
> > So a single 'dbus.c:21:10: fatal error: dbus/dbus.h: No such file or directory'
> > in the NixOS world, shows up here as request for, example given,
> > 
> > > -MANDIR        = $(PREFIX)/share/man
> > > +MANDIR        ?= $(PREFIX)/share/man
> > 
> > 
> > With whole commit message 'Makefile: make variables overridable'.
> > 
> > 
> > 
> > Patch reviewed and rejected.
> > 
> 
> Reviewed is one thing, but rejected by a non-maintainer of the project
> is out of line.
> 
> 'Geert Stappers' is not in anyway a maintainer of the Dnsmasq project
> nor am I.
> While the patch might not be addressing the core of this issue, being
> able to overwrite variable is worth considering in anycase.

All true.


Regards
Geert Stappers
Looking forward to a revisited patch.
-- 
Silence is hard to parse



More information about the Dnsmasq-discuss mailing list