[Dnsmasq-discuss] [PATCH] Accept PKG_CONFIG from environment

[Petr Menšík]

Did you know both BSD make and GNU make allows to override variables on
command line?

if command parameter is used instead of environment, it would work
without a change:

make PKG_CONFIG=/usr/local/sbin/pkg-config

But I admit it is inconvenient. If they need custom path just to
PKG_CONFIG, it might be sufficient. However, should not be this updated
just by different PATH order?

Wouldn't PKG_CONFIG_PATH change make more sense? Is this required?

On 7/12/20 10:25 PM, Geert Stappers wrote:
> From: Geert Stappers <stappers at stappers.nl>
> 
> Dnsmasq has not yet a portable build system.
> Famous is GNU autoconf which generates Makefiles.
> To avoid such large change this simple change.
> 
> It allows that PKG_CONFIG can be overriden.
> That PKG_CONFIG is set by the build environment,
> so no need to modify the Makefile in that env.
> 
> Reported by the NixOS project.
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 78e25f0..55bccbe 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -34,7 +34,7 @@ LIBS          =
>  
>  # Variables you might want to override.
>  
> -PKG_CONFIG = pkg-config
> +PKG_CONFIG ?= pkg-config
>  INSTALL    = install
>  MSGMERGE   = msgmerge
>  MSGFMT     = msgfmt
> 

-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB