[Dnsmasq-discuss] [PATCH] --bind-dynamic and fast netlink changes

[Petr Menšík]

On 3/1/21 1:02 AM, Simon Kelley wrote:
> That looks sensible except for one thing. I wasn't sure about the
> logging in the first place, and having to add Yet Another Config Option
> to control it is the last straw; I think it's better just removed.
Is there any good way to monitor them without logging possible? I
considered also enabling the log just in debug mode (-d). It seems
better if it can be configured separately. Still, I find those logs very
important to observe listener changes. It was hard to watch more than
single change using debugger.

I also considered using log-queries option, because it logs quite often
anyway. But I think it would be better to have separate option.

Logging those events seems right to me. But they should not be logged
during netlink reading, but after it. It seems quite complicated to
gather changed listeners after iface_enumerate is finished however. They
are usually just one or two lines, just during my artificial test, it
was worth noting. I should mention, the first commit itself fixed it
well on 2.79 in RHEL8. Listeners logging still in place and slowing down
the test. Yet it always passed.

I removed them just as precaution to improve performance. As a last
resort, could they remain there under compile time define?

> 
> 
> Will apply the others and test tomorrow.
Great, if you need help with testing, just let me know.

Cheers,
Petr

-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20210301/fc6bd424/attachment-0001.sig>