[Dnsmasq-discuss] Cannot forward TCP query after v2.85rc1 (branch master)

[Petr Menšík]

I am sorry for typo mistakes. I have to finish some easy to run testing.
Not useful only for my contributions where I might have overlooked
something like this. Some CI should have slapped me for that mistake.
Thanks for checking it it instead. Would try to make some automatic
checker for basic functionality. Also checking it a bit more before
sending changes.

Thanks.

On 3/22/21 11:05 PM, Simon Kelley wrote:
> Many thanks. Patch applied.
> 
> 
> Simon.
> 
> 
> On 22/03/2021 11:49, 黎醒聪 wrote:
>> Use dig to reproduce this bug, it will TCP timeout.
>>
>> dig example.com <http://example.com> +tcp
>>
>> It should be introduced in commit 51f7bc924cbcdeb09cbb83249b70c121d1ffa31e
>>
>> I try to fix this typo and the TCP query works as usual:
>>
>> Change tcp_request() in forward.c:
>>
>> Wrong:
>> server_send(last_server, last_server->tcpfd, packet, m + sizeof(u16),
>> MSG_FASTOPEN);
>>
>> Correct:
>> server_send(last_server, last_server->tcpfd, packet, size + sizeof(u16),
>> MSG_FASTOPEN);
>>
>> Go on and fix, thanks!
>>
>> Kinds regards,
>>
>> Xingcong Li
>>
>> _______________________________________________
>> Dnsmasq-discuss mailing list
>> Dnsmasq-discuss at lists.thekelleys.org.uk
>> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
>>
> 
> 
> _______________________________________________
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss at lists.thekelleys.org.uk
> https://lists.thekelleys.org.uk/cgi-bin/mailman/listinfo/dnsmasq-discuss
> 

-- 
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20210323/21d88ff6/attachment.sig>