[Dnsmasq-discuss] [PATCH] unittests

- Neustradamus - neustradamus at hotmail.com
Thu Apr 15 14:26:59 UTC 2021


Hello Simon, and all others,

Here, I see a fork of Dnsmasq on GitHub, thanks Petr :)

Can you look for https://github.com/dnsmasq organization and add the https://github.com/dnsmasq/dnsmasq after it?
And remove the old https://github.com/simonkelley/dnsmasq-collab which is a fork of https://github.com/sei-vsarvepalli/dnsmasq-collab.

The goal is to have a best development of Dnsmasq, and more contributors, improvements etc.
It will be better to devs to fork directly the dnsmasq/dnsmasq.

If this repo is a real mirror (without changes), I can see with Vladislav Grishenko (themiron) to transfer directly into dnsmasq organization.
- https://github.com/themiron/dnsmasq

Thanks in advance.

Regards,

Neustradamus

________________________________________
From: Dnsmasq-discuss <dnsmasq-discuss-bounces at lists.thekelleys.org.uk> on behalf of Petr Menšík <pemensik at redhat.com>
Sent: Wednesday, April 14, 2021 19:35
To: dnsmasq-discuss at lists.thekelleys.org.uk
Subject: [Dnsmasq-discuss] [PATCH] unittests

Hi Simon and other dnsmasq friends,

after some struggling with Makefile support, I am sending my dnsmasq
unit tests. It uses another directory with tests specific code. I moved
some common parts to Makefile.config, in order to be able to reuse them.
Unit tests are under tests directory with own Makefile.

New target make check should work also from top directory. Some checks
would work only from tests directory (make kyua). Current coverage is
rather poor, but I hope can be used as a building block to better tests.
Especially option parsing tests are easy to write. Testing of sending
and receiving packets seems to be difficult, it should be tested by
different kind of test IMHO.

First is attempt to refactor, the second is what evolved into more
complex set of tests.

Original separate commits are still available on github [1].

What do you think?

PS: sending this message again, because patch #2 were big enough to
require moderator's approval. Compressed it as a workaround.

Cheers,
Petr

1. https://github.com/InfrastructureServices/dnsmasq/tree/unittests
--
Petr Menšík
Software Engineer
Red Hat, http://www.redhat.com/
email: pemensik at redhat.com
PGP: DFCF908DB7C87E8E529925BC4931CA5B6C9FC5CB




More information about the Dnsmasq-discuss mailing list