[Dnsmasq-discuss] Patch with option to filter A records

Geert Stappers stappers at stappers.nl
Sat Jun 5 15:37:25 UTC 2021


On Sat, Jun 05, 2021 at 03:34:59PM +0200, Trey Sis wrote:
> Hello everyone!
 
:-)


> I have created a patch that adds an option to dnsmasq to filter
> out A record requests. This is particularly suitable for IPv6-only
> environments. Some software (especially NodeJS) will reorder
> DNS requests giving priority to A records, irrespective of IPv4
> connectivity of the host. My patch filters A records, while AAAA
> records are returned.
> 
> In theory, the OS shouldn't send A records requests in the first place,
> if no IPv4 connectivity exists. Otherwise, most OS don't send AAAA
> record requests if no IPv6 connectivity exists. So my patch mitigates
> some of the problems in IPv6-only environments.

I do like the idea.

 
> Is there any chance for such a patch to make it into official
> dnsmasq? Are pull-requests on github acted on? That would be my
> preferred method, otherwise I will post the patch here.
> 
> Cheers,
> Treysis
> 
> Patch:
> 
> >From bd22a36f76e35a0dc6c8be8996056318fec96e5e Mon Sep 17 00:00:00 2001
> From: treysis <treysis at gmx.net>
> Date: Sat, 5 Jun 2021 15:27:26 +0200
> Subject: [PATCH] Add option to filter A record requests
> 
> ---
>  src/dnsmasq.h |  3 ++-
>  src/option.c  |  3 +++
>  src/rfc1035.c | 11 +++++++++++
>  3 files changed, 16 insertions(+), 1 deletion(-)
> 

That patch did not apply cleanly. With some manual work it did apply.
Except to see the reworked version here soon.
Hopefully is Author left intact. (I'm about to `git send-email` a patch
that is not mine ).
And the original patch lacks update of the manual page,
it is where I chip in.


Cheers
Geert Stappers

P.S.
https://git-send-email.io/ for instructions on email patches.
See "Linux kernel development all over the place" in it.



More information about the Dnsmasq-discuss mailing list