[Dnsmasq-discuss] file not found messages from tftp

Geert Stappers stappers at stappers.nl
Thu Jul 8 20:38:36 UTC 2021


On Thu, Jul 08, 2021 at 07:46:37PM +0000, Kevin Darbyshire-Bryant wrote:
> On 8 Jul 2021, at 18:30, Kevin Darbyshire-Bryant wrote:
> >> On 8 Jul 2021, at 17:10, Aleksander Mazur wrote:
> >> 
> > <snip>
> >> I'm sorry but I don't understand your point.
> >> AFAIK valid DNS query requests are already completely hidden (not even under
> >> DEBUG). Does it feel wrong as well?
> >> 
> >> Anyway, those fake TFTP errors turn my syslog into dnsmasq's verbose trace log.
> >> Lowering their severity to DEBUG (since they are completely useless unless you
> >> are debugging dnsmasq or PXE/TFTP client) restores usability of the syslog.
> > 
> > I wonder if there is a third way - At the risk of yet another dnsmasq
> > option I note that ‘—-quiet-tftp’ does not yet exist.
> 
> It does now!  See attached patch - unbelievably this compiled 1st time
> for me which is unbelievable with my history on C typos - not actually
> run tested.
> 

Patch applies cleanly, which is good.

The gist is

--- a/src/tftp.c
+++ b/src/tftp.c
@@ -761,7 +761,8 @@ static ssize_t tftp_err(int err, char *packet, char *message, char *file)
   len = snprintf(mess->message, MAXMESSAGE,  message, file, errstr);
   ret += (len < MAXMESSAGE) ? len + 1 : MAXMESSAGE; /* include terminating zero */

-  my_syslog(MS_TFTP | LOG_ERR, "%s", mess->message);
+  if ((option_bool(OPT_QUIET_TFTP) && err != ERR_FNF) || !option_bool(OPT_QUIET_TFTP))
+    my_syslog(MS_TFTP | LOG_ERR, "%s", mess->message);

   return  ret;
 }


Which text should go in the manual page?





Groeten
Geert Stappers
-- 
Silence is hard to parse



More information about the Dnsmasq-discuss mailing list