[Dnsmasq-discuss] file not found messages from tftp

Simon Kelley simon at thekelleys.org.uk
Fri Jul 9 21:51:18 UTC 2021


On 09/07/2021 21:14, Aleksander Mazur wrote:
> Dnia 2021-07-08, o godz. 21:24:49
> Kevin Darbyshire-Bryant <kevin at darbyshire-bryant.me.uk> napisał(a):
> 
>>> On 8 Jul 2021, at 20:46, Kevin Darbyshire-Bryant
>>> <kevin at darbyshire-bryant.me.uk> wrote:
>>>
>>> It does now!  See attached patch - unbelievably this compiled 1st time for
>>> me which is unbelievable with my history on C typos - not actually run
>>> tested.  
>> V2 with a manpage tweak at no extra charge
>>
> 
> Thanks!
> Could you please explain what is the advantage of
> 
> if ((option_bool(OPT_QUIET_TFTP) && err != ERR_FNF) || !option_bool(OPT_QUIET_TFTP))
> 
> over just the following?
> 
> if (err != ERR_FNF || !option_bool(OPT_QUIET_TFTP))
> 


Kevin's patch applied, with Aleksander's reduction of the boolean
expression added.

Thanks both.


Simon.




More information about the Dnsmasq-discuss mailing list