[Dnsmasq-discuss] [PATCH 3] Some upstream replies not being logged

Dominik DL6ER dl6er at dl6er.de
Wed Sep 1 11:45:04 UTC 2021


Hey Simon,

On Tue, 2021-08-31 at 21:09 +0100, Simon Kelley wrote:
> I've tagged 2.86rc2. I've systematically tested the affected code,
> and we're dog-fooding it now. It would be good to get as much other
> testing in as possible before the 2.86.

We have automated CI testing putting a lot of queries (and different
query types) through it and nothing unexpected happened.
We've added the patch into our beta testing so we have at least a few
dozen additional testers of the new code on our side, too.

I've seen two minor things but this is really nit-picky:

> dig TYPE65 https.dns.netmeister.org

leads to

> reply https.dns.netmeister.org is type=65

whereas I'd consider

> reply https.dns.netmeister.org is [type=65]

slightly more elegant because it is the type of the reply, not the
content. The necessary change would be querystr(NULL, aqtype) ->
querystr("", aqtype) in the "else" branch of "if (aqtype == T_TXT)" but
that's entirely your call.

Also, DNSSEC signed TXT records were not logged as such with log-
queries=extra. print_txt() needs secflag for this. Patch attached.

I'll report back if anything odd comes up. Silence will be a good
thing.

Best,
Dominik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Print-DNSSEC-signed-for-signed-TXT-records-when-log-.patch
Type: text/x-patch
Size: 1895 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20210901/ba220a99/attachment.bin>


More information about the Dnsmasq-discuss mailing list