[Dnsmasq-discuss] Extremely long startup times when using libidn2 (and proposed fix)

Simon Kelley simon at thekelleys.org.uk
Thu Sep 9 23:15:41 UTC 2021


On 08/09/2021 22:10, Gustaf Ullberg wrote:
> Thanks Petr for having a look at this.
> Since IDN processing do turns uppercase letters into lowercase, I
> deliberately left uppercase letters out.
> I think your approach to put everything in check_name() makes sense,
> even if that function grows and maybe is starting to become a bit hard
> to read.
> 
> I took your patch and made a couple of changes:
> - IDN processing is performed if there are uppercase letters present in
> the name (unless we have an old version of libidn2 and there is an
> underscore in the name).
> - IDN processing is always performed if there are non-ascii characters
> in the name, no matter if there are underscores or not (a non-processed
> name containing non-ascii characters sounds dangerous).
> 

That's an improvement. Applied in place of Petr's patch.

Cheers,


Simon.



More information about the Dnsmasq-discuss mailing list