[Dnsmasq-discuss] [PATCH] Two small fixes

Dominik Derigs dl6er at dl6er.de
Tue Sep 28 10:05:56 UTC 2021


Hey Petr and Simon,

On Mon, 2021-09-27 at 23:03 +0100, Simon Kelley wrote:
> Petr, this code seems to have last been touched by you, in
> 
> ad59f278c6234a416f36dfdd39143bb46f5d707a
> 
> can you remember what that was supposed to achieve? None of it is
> making
> much sense to me.

Looks like we need more comments in the code from time to time to
remind ourselves what it is supposed to do. Joking aside: I think
this can be reversed, at least partially. Even on operating
systems not supporting labels, we have

>   if (!label)
>     label = ifr.ifr_name;

which should preserve backwards compatibility it I'm not
mistaken. And since we're using the label variable everywhere
else...

Best,
Dominik




More information about the Dnsmasq-discuss mailing list