[Dnsmasq-discuss] [PATCH] Fix segfault and regressions in option --rebind-domain-ok

[guns]

On Thu  9 Dec 2021 at 12:04:52AM +0000, Simon Kelley wrote:
> On 18/11/2021 18:21, Sung Pae wrote:
> > Hello list,
> >
> > The --rebind-domain-ok option is broken in v2.86 and on master in the
> > following ways:
>
> Thanks for the clear and complete bug report. I accept that these are
> bugs and regressions. I applied your first patch as is, but the second
> one seems to be a way over-complicated fix. I've therefore taken the
> liberty of fixing the issue a different way. Please see
> https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=1176cd58c90fc37bf98a6f774b26fc1adc8fd8e9

Yes, checking suffix equality and then evaluating whether the domain is
an exact match or a subdomain is indeed simpler than introducing generic
substring subroutines. Part of the motivation of supplying a patch is to get
an author's attention, and in that I have been successful.

> If you could test that, and make sure I didn't break things differently, I'd
> be very grateful.

Your fix works well. Thank you for work on dnsmasq. Being able to easily
control DNS and DHCP on my networks has been a real joy.

Sung Pae
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/attachments/20211209/bd8e3c6f/attachment.sig>