[Dnsmasq-discuss] Snapshot archives downloaded from gitweb are not versioned properly

[Johnny S. Lee]

Hello Geert,

On Mon, 12 Sept 2022 at 14:26, Geert Stappers wrote:
>
> Hello Johnny,
> ( Cc: dnsmasq-discuss at lists.thekelleys.org.uk )
>
>
> On Mon, Sep 12, 2022 at 11:51:22AM +0800, Johnny S. Lee via Dnsmasq-discuss wrote:
> > The contents of file VERSION from the tar.gz files of the latest 3 commits:
> >
> > dnsmasq-c4b9bc6/VERSION: (HEAD -> master)
> > dnsmasq-4447d48/VERSION: (tag: v2.87rc1, origin/master, origin/HEAD)
> > dnsmasq-04cc2ae/VERSION:
>
> I do read "there is something wrong", but I don't get what.
> Hopefully do others understand it. If not, elaborate the inconvenience.
>
>

I mean VERSION files in snapshot archives downloaded from
https://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=summary
are not always filled with meaningful contents, unless the commit is tagged.
When you run `dnsmasq --version` using binary built from those archives,
it might show '(HEAD -> master)' or blank as the version.

> > Would it be better adding "%(describe)" to the format in file VERSION?
>
> I do read that as "I might have a solution for it".
> I tried to understand it and my attempt did bring:
>
> --- a/VERSION
> +++ b/VERSION
> @@ -1 +1 @@
> -$Format:%d$
> +$Format:%d %(describe)$
>
>
> Is that what you are trying to say?
>
>

Right, something like that. bld/get-version should also be updated though.

>
> Groeten
> Geert Stappers
> --
> Silence is hard to parse