[Dnsmasq-discuss] Snapshot archives downloaded from gitweb are not versioned properly

[Johnny S. Lee]

> How often is the VERSION file changed?

It changes from "(HEAD -> master)" to blank when there is a new commit.
Checksum of the archive of the same commit probably changes too.

> Is the VERSION file meaningful only at the time of a release and can change 'drastically' between releases?

It's meaningful when the source directory is not a git repo.
When building from a git repo, `git describe` is run for getting the version.
I would expect snapshot archives to have the same.


On Mon, 12 Sept 2022 at 15:22, <imnozi at gmail.com> wrote:
>
> On Mon, 12 Sep 2022 08:26:14 +0200
> Geert Stappers via Dnsmasq-discuss <dnsmasq-discuss at lists.thekelleys.org.uk> wrote:
>
> > Hello Johnny,
> > ( Cc: dnsmasq-discuss at lists.thekelleys.org.uk )
> >
> >
> > On Mon, Sep 12, 2022 at 11:51:22AM +0800, Johnny S. Lee via Dnsmasq-discuss wrote:
> > > The contents of file VERSION from the tar.gz files of the latest 3 commits:
> > >
> > > dnsmasq-c4b9bc6/VERSION: (HEAD -> master)
> > > dnsmasq-4447d48/VERSION: (tag: v2.87rc1, origin/master, origin/HEAD)
> > > dnsmasq-04cc2ae/VERSION:
> >
> > I do read "there is something wrong", but I don't get what.
> > Hopefully do others understand it. If not, elaborate the inconvenience.
>
> *I* might expect the displayed version info to contain reasonably consistent information. How often is the VERSION file changed? Is the VERSION file meaningful only at the time of a release and can change 'drastically' between releases? Or should it contain data like "tag: v2.87rc1, origin/master, origin/HEAD" through the life of rc1 (for example)?
>
> N
>
> >
> >
> > > Would it be better adding "%(describe)" to the format in file VERSION?
> >
> > I do read that as "I might have a solution for it".
> > I tried to understand it and my attempt did bring:
> >
> > --- a/VERSION
> > +++ b/VERSION
> > @@ -1 +1 @@
> > -$Format:%d$
> > +$Format:%d %(describe)$
> >
> >
> > Is that what you are trying to say?
> >
> >
> >
> > Groeten
> > Geert Stappers
>