[Dnsmasq-discuss] [PATCH] Removed empty last lines
Geert Stappers
stappers at stappers.nl
Sat Oct 22 20:20:18 UTC 2022
On Sat, Oct 22, 2022 at 09:26:53PM +0200, Geert Stappers wrote:
> Files src/domain-match.c and src/metrics.c had empty last lines.
> Now has the last line of those files more than just white space.
>
> Signed-of-by: Geert Stappers <stappers at stappers.nl>
> ---
> src/domain-match.c | 1 -
> src/metrics.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/src/domain-match.c b/src/domain-match.c
> index 76a1109..219331c 100644
> --- a/src/domain-match.c
> +++ b/src/domain-match.c
> @@ -729,4 +729,3 @@ int add_update_server(int flags,
>
> return 1;
> }
> -
> diff --git a/src/metrics.c b/src/metrics.c
> index f3e6728..139ad4a 100644
> --- a/src/metrics.c
> +++ b/src/metrics.c
> @@ -63,4 +63,3 @@ void clear_metrics(void)
> serv->query_latency = 0;
> }
> }
> -
> --
> 2.11.0
>
The thing I aiming for is "formatting by machine".
So that tooling can enforce Coding Style.
Reason for raising this issue again, is seeing in a short time:
https://www.reddit.com/r/rust/comments/y935fn/comment/it3tvum/?utm_source=reddit&utm_medium=web2x&context=3
* rustfmt would make the indentation match the semantics. clang-format probably would do the same
https://nuttx.apache.org/docs/latest/introduction/inviolables.html#clear-consistent-standardized-coding-style
* Strict conformance to the NuttX coding style. No “revolutionary”
changes to the coding standard (but perhaps some “evolutionary” changes).
* Personal or organizational preference is not a justification for a
coding style change.
* Nothing can come into NuttX that does not follow the coding standard.
* Expediency is not a justification for violating the coding standard.
Groeten
Geert Stappers
--
Silence is hard to parse
More information about the Dnsmasq-discuss
mailing list