[Dnsmasq-discuss] Coding Style

Geert Stappers stappers at stappers.nl
Sun Oct 23 18:37:51 UTC 2022


In-Reply-To: <20221022202018.cxxx2lag6dxqgivw at gpm.stappers.nl>
Previous-Subject: Re: [Dnsmasq-discuss] [PATCH] Removed empty last lines
On Sat, Oct 22, 2022 at 10:20:18PM +0200, Geert Stappers via Dnsmasq-discuss wrote:
> On Sat, Oct 22, 2022 at 09:26:53PM +0200, Geert Stappers wrote:
> > Files src/domain-match.c and src/metrics.c had empty last lines.
> > Now has the last line of those files more than just white space.
> > 
> > diff --git a/src/domain-match.c b/src/domain-match.c
> > --- a/src/domain-match.c
> > +++ b/src/domain-match.c
> > @@ -729,4 +729,3 @@ int add_update_server(int flags,
> >    
> >    return 1;
> >  }
> > -
> > diff --git a/src/metrics.c b/src/metrics.c
> > --- a/src/metrics.c
> > +++ b/src/metrics.c
> > @@ -63,4 +63,3 @@ void clear_metrics(void)
> >        serv->query_latency = 0;
> >      }
> >  }
> > -	
> > 
> 
> The thing I aiming for is "formatting by machine".
> So that tooling can enforce Coding Style.
> 

Differences against previous attempt:

* `git blame` can be told to ignore certain commits
* `clang-format` improved
* We became wiser


This email will get patches as follow-up message.

Expect to see a machine readable format description,
git blame commit ignore instructions and a CodingStyle file.


I'm looking forward to your feedback.


Groeten
Geert Stappers
-- 
Silence is hard to parse



More information about the Dnsmasq-discuss mailing list